Make GetMountsFromReader linux-only #38
Conversation
GetMountsFromReader was a wrapper for parseInfoFile on Linux. All other implementations do not parse `mountinfo`, so had to stub out the implemetation and omit the actual reader. (worse, a FreeBSD implementation was missing, causing compile on that to fail). This patch makes GetMountsFromReader linux-only, as it was added to allow benchmarking the `mountinfo` parsing, which only makes sense on Linux. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
| // reader provided, with an optional filter applied (use nil | ||
| // for no filter). This can be useful in tests or benchmarks | ||
| // that provide a fake mountinfo data. | ||
| func GetMountsFromReader(reader io.Reader, f FilterFunc) ([]*Info, error) { |
There was a problem hiding this comment.
Now that GetMountsFromReader is effectively just an alias for parseInfoFile, should we just export parseInfoFile on Linux instead?
Looks like it's not used anywhere currently https://grep.app/search?q=mountinfo.GetMountsFromReader
There was a problem hiding this comment.
It is used in a few places, so I'd rather not change the name. Surely we can just rename parseInfoFile to GetMountsFromReader, if this is what you mean
One such place is opencontainers/runc@999ff3f, and another is
There was a problem hiding this comment.
... and another is moby/moby#40694
There was a problem hiding this comment.
Nope, it's not it. I don't remember why I added it but I definitely had a good reason to :-)
There was a problem hiding this comment.
But surely it makes sense to make it Linux-only
|
@kolyshkin ptal <3 |
closes #35
GetMountsFromReader was a wrapper for parseInfoFile on Linux.
All other implementations do not parse
mountinfo, so had tostub out the implemetation and omit the actual reader.
(worse, a FreeBSD implementation was missing, causing compile on
that to fail).
This patch makes GetMountsFromReader linux-only, as it was added
to allow benchmarking the
mountinfoparsing, which only makessense on Linux.