go: fix binding of privileged UDP ports via vmnetd #485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Scott <dave.scott@docker.com>
This mirrors the fix that we already had for TCP. Signed-off-by: David Scott <dave.scott@docker.com>
On Mojave, binding to 0.0.0.0:80 will work but binding to 127.0.0.1:80 will fail (and still require vmnetd) Signed-off-by: David Scott <dave.scott@docker.com>
|
Ignoring the OCaml broken CIs, travis is green for the Go code. This also passes the Docker Desktop end-to-end tests for extra safety. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously in 32ede13 we added a fix for TCP where we didn't set the socket to non-blocking mode. This PR replicates the fix for UDP and adds a unit test.
Related to docker/for-mac#3775
Furthermore this PR only uses the
vmnetdcode path if the bind actually fails with permission denied. In particular on Mojave, some binds will succeed (e.g.0.0.0.0:80) without being root.