Skip to content
This repository has been archived by the owner on May 21, 2021. It is now read-only.

Added support for secure WebSockets #9

Closed
wants to merge 4 commits into from
Closed

Added support for secure WebSockets #9

wants to merge 4 commits into from

Conversation

CPlusPlus17
Copy link

My English is not the best, maybe you want to adjust the documentation to fit your standards. :)

@EnTeQuAk
Copy link
Contributor

Hey @ManuelGysin - thanks a lot for the pull request!

I am actually not sure if we really want ssl support in omnibus directly. I'd rather see the documentation adapted with howtos to use nginx, apache etc as a https-proxy or an example using stunnel as a tunnel for local development.

Let me know what you think

@CPlusPlus17
Copy link
Author

Hello!

To be honest, I'm not very familiar with websockets nor how to protect them the right way.
But in my opinion direct support would help to make the web a bit more secure, most people are not willing to install https-proxies or stuff like that and so they just skip the SSL part. (Deployment gets much more complex)

I can't estimate the impact of adding the SSL layer directly to omnibus. Sure there is some more CPU work to do but it will help to keep the deployment small. The other part is with omnibus and http-proxy in use the network debugging part could get much more complex.

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.65%) when pulling 441824b on ManuelGysin:master into f3c453a on moccu:master.

@EnTeQuAk
Copy link
Contributor

Thanks again for all the work you did. I'm going to close this in favor of #17 to give this topic a bigger picture.

@EnTeQuAk EnTeQuAk closed this Jul 29, 2014
siicosmos pushed a commit to siicosmos/django-omnibus that referenced this pull request May 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants