Fusion based 404 handling #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Reviews and feedback is very welcome. Maybe @ComiR @kdambekalns you are interested in reviewing it. |
ComiR
reviewed
Jan 13, 2020
There was a problem hiding this comment.
Currently I'm not working on any projects anymore where I could test this.
Perhaps @franzkugelmann could give it a try?
| @@ -16,7 +16,7 @@ | |||
| } | |||
| ], | |||
| "require": { | |||
| "neos/neos": ">3.3" | |||
| "neos/neos": ">=4.3" | |||
There was a problem hiding this comment.
I'd rather use ^4.3 | ^5.0 to prevent incompatibilities like the ones caused by > (which will haunt this package forever, but will obviously need less maintenance if it will be compatible with f.e. Neos 6.0).
|
Great! Looks good to me and is working just fine with the latest Neos 5.1.3 and two language dimensions. |
aertmann
approved these changes
Jan 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrite of the 404 handling to new Neos internal error handling in fusion.
Change is breaking as configuration for it has changed, so a new major version is needed. Lowest supported Neos version is 4.3.
Supports multiple dimensions, also single and no dimensions.