Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add playwright exmaple #37

Merged
merged 13 commits into from
Sep 3, 2020

Conversation

irrationnelle
Copy link
Contributor

Playwright is recently considered interesting automate tool for browser like selenium, puppeteer.
But there is no example for Playwright yet, so I suggest this PR.
IMHO, this example is very simple and quintessential, but any feedback could improve also this PR.
Thank you!

Copy link
Contributor

@craigtaub craigtaub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, nice example 👍🏻

@@ -0,0 +1,7 @@
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can probably remove the values which are the default, i.e. everything except timeout.

@irrationnelle
Copy link
Contributor Author

Thank you for feedback!

.mocharc.json is removed and timeout option is moved to package.json.

and to pass Travis CI, I modified below:

  • add timeout option with 10000 value for selenium and vue-puppeteer

  • add Promise to async operation of node-sqlite3, because sometimes test is failed against non-existent value. Check here. IMHO, this would be an asynchronous problem, for example 1) before insert value, request value from table 2) first create table and then drop table. I would like to ask @MoonSupport to confirm my idea 🙏.

@irrationnelle
Copy link
Contributor Author

I missed something out.

chromedriver is updated with ^85.0.0 to pass Travis CI that installed chrome v85 as stable version for selenium example.

@craigtaub craigtaub merged commit 2fe8393 into mochajs:master Sep 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants