Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unbreak mocha --inline-diffs #1044

Closed

Conversation

papandreou
Copy link
Contributor

Previously mocha --inline-diffs threw a ReferenceError:

/path/to/mocha/bin/_mocha:215
if (program.inlineDiffs) Base.inlineDiffs = true;
                         ^
ReferenceError: Base is not defined
    at Object.<anonymous> (/path/to/mocha/bin/_mocha:215:26)
    at Module._compile (module.js:456:26)
    at Object.Module._extensions..js (module.js:474:10)
    at Module.load (module.js:356:32)
    at Function.Module._load (module.js:312:12)
    at Function.Module.runMain (module.js:497:10)
    at startup (node.js:119:16)
    at node.js:901:3

Seems like it broke in this refactoring: 805c95d

This fix doesn't seem like it's the entirely correct way to get the inlineDiffs option set on the base reporter, but it's a start.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant