You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Just like you can configure test timeout per test, it would be handy to educate the global leak detection system to ignore certain globals on a per test basis. In cases where you are testing different code paths (maybe for legacy browsers) you want to allow some globals but then other tests you want to make sure those globals don't exist.
I am happy to make the PR if this is something others think should exist too (I couldn't find it in the current code).
The text was updated successfully, but these errors were encountered:
I implemented this with as minimal impact to the codebase for simpler review however I think a better architectural solution is to move more of the checking into the Runnable so that the suite/runner will always ask the runnable to check globals after it runs versus passing the test back into the Runner.
Just like you can configure test timeout per test, it would be handy to educate the global leak detection system to ignore certain globals on a per test basis. In cases where you are testing different code paths (maybe for legacy browsers) you want to allow some globals but then other tests you want to make sure those globals don't exist.
I am happy to make the PR if this is something others think should exist too (I couldn't find it in the current code).
The text was updated successfully, but these errors were encountered: