Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow certain globals on a per test basis #1045

Closed
defunctzombie opened this issue Nov 21, 2013 · 3 comments
Closed

allow certain globals on a per test basis #1045

defunctzombie opened this issue Nov 21, 2013 · 3 comments

Comments

@defunctzombie
Copy link
Contributor

Just like you can configure test timeout per test, it would be handy to educate the global leak detection system to ignore certain globals on a per test basis. In cases where you are testing different code paths (maybe for legacy browsers) you want to allow some globals but then other tests you want to make sure those globals don't exist.

I am happy to make the PR if this is something others think should exist too (I couldn't find it in the current code).

@travisjeffery
Copy link
Contributor

ya i saw a related issue/request about this - it shouldn't take too much code so feel free to make a pr and i'll take a look

@defunctzombie
Copy link
Contributor Author

PR #1046 created for this issue.

I implemented this with as minimal impact to the codebase for simpler review however I think a better architectural solution is to move more of the checking into the Runnable so that the suite/runner will always ask the runnable to check globals after it runs versus passing the test back into the Runner.

@travisjeffery
Copy link
Contributor

merged that pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants