Remove invalid optimization in checkGlobals(). #1110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
travisjeffery
added a commit
that referenced
this pull request
Jan 21, 2014
Remove invalid optimization in checkGlobals().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1015
There was an attempt at an optimization in checkGlobals that would short circuit globals checking if the number of tolerated globals was equal (correcting for a couple of expected differences) to the number of actual globals. This is completely invalid since you could tolerate a new global in your mocha config and the system under test could add a different global but not the new global you are tolerating. (Or you could tolerate two new ones, and two new unexpected ones could be added by the system under test, etc.) In these cases, the unexpected globals will not be reported by mocha and tests will pass when they should not. So basically the code was assuming that the system under test would DEFINITELY add any globals that were added to the list of tolerated globals through mocha config.
I added a test for the simplest failure case, saw it fail, and then removed the offending code.