Fix failing tests, upgrade to should 4.0 #1231
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I tried to clone the repo and run the tests, 9 of them were failing. Needless to say, it's a little unsettling to use a testing framework with failing tests.
I fixed the failing tests and upgraded the
should
dev dependency to 4.0. Seems the tests were failing because they were looking for properties on should'sAssertion
object that were not present, namelystatus
andinclude
.