Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Providing an api for disableTimeouts() in tests. #1268

Conversation

jsdevel
Copy link
Contributor

@jsdevel jsdevel commented Jul 13, 2014

/cc @travisjeffery

This is in response to some feedback for #1262 after it was merged.

Please let me know what you think. Thanks.

@jsdevel jsdevel changed the title Providing an api for disableTimeouts() to tests. Providing an api for disableTimeouts() in tests. Jul 13, 2014
@jsdevel
Copy link
Contributor Author

jsdevel commented Jul 13, 2014

@travisjeffery I'm not sure the specs would be able to modify disableTimeouts at that point in time as the timeout would have already been issued. Can you give me some guidance? I wasn't aware that this.timeout() had no cascade effect. All is well now.

@jsdevel jsdevel mentioned this pull request Jul 13, 2014
@travisjeffery
Copy link
Contributor

ok see my inline comments and use this api to do #1262

@jsdevel
Copy link
Contributor Author

jsdevel commented Jul 14, 2014

@travisjeffery do you mean that you'd like the tty flag removed?

@travisjeffery
Copy link
Contributor

don't worry about it, i'll fix it.

@jsdevel
Copy link
Contributor Author

jsdevel commented Jul 14, 2014

@travisjeffery will mocha be able to signal _mocha that it's in debug mode? I was thinking the main use case for --disable-timeouts would be to handle this scenario.

@jsdevel jsdevel deleted the providing-an-api-for-disableTimeouts-in-tests branch July 14, 2014 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants