Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix tests that need to be uncommented #1528

Closed
dasilvacontin opened this issue Feb 3, 2015 · 2 comments
Closed

fix tests that need to be uncommented #1528

dasilvacontin opened this issue Feb 3, 2015 · 2 comments

Comments

@dasilvacontin
Copy link
Contributor

Some tests ask to be uncommented to see actual behaviour, because they are designed to fail.

Instead of doing that, another instance of mocha should be run and then test on that instance if the before/after/tests are run/failed/etc. Kinda of what I've done at test/mocha.js.
@dasilvacontin
Copy link
Contributor Author

Thanks to @geoguide we've also discovered that async errors are reported as 'Uncaught'. All the tests that 'need to be uncommented to check behaviour' should be improved, IMO.

@jbnicolai jbnicolai added the status: accepting prs Mocha can use your help with this one! label Jul 5, 2015
@glenjamin glenjamin mentioned this issue Jul 5, 2015
Merged
@jbnicolai
Copy link

Closed thanks to the great work of @glenjamin in #1781

@boneskull boneskull removed the status: accepting prs Mocha can use your help with this one! label Oct 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@boneskull @dasilvacontin @jbnicolai