this.skip() completely broken if html reporter used.

[Kirill89]

Demo: https://github.com/Kirill89/mocha-test

Error: TypeError: test.err is undefined (http://localhost:1111/node_modules/mocha/mocha.js:2786)

• Firefox 38.0.5
• Chrome 43.0.2357.124 (64-bit)

[boneskull]

what are you trying to accomplish by skipping the hook?

[Kirill89]

@boneskull I'm trying skip whole "describe" section.

[Kirill89]

@boneskull mocha already has same test, and it is works for reporter "spec". Can you explain me why doesn't work for "html" reporter?

[danielstjules]

Looks like you're right. Avoiding async hooks/specs, I was able to replicate in the browser:

describe('foo', function () {
  before(function() {
    this.skip();
  });

  it('bar', function() {
    // test
  });
});

From the console:

  foo
    - bar


  0 passing (9ms)
  1 pending

But in the browser:

So seems like it's not being correctly labeled as pending.

[danielstjules]

@Kirill89 Are you able to get this.skip() to work from a spec, in the browser?

describe('foo', function () {
  it('bar', function() {
    this.skip();
  });
});

[Kirill89]

@danielstjules I am surprised, but it is also doesn't work. But with another error.

[danielstjules]

Thanks for confirming! Both errors are being propagated by the HTML reporter due to it trying to act on a nonexistent err property for the test, since it wasn't correctly marked as pending. Will look into where that regression may have been introduced. Appreciate your help!

[SerkanSipahi]

really nice feature this.skip( what I was looking for ) in hooks(before, after, etc). My question: why is that not documented? it there more nice magic features what is not documented? :)

[puzrin]

@danielstjules any chances to get it fixed soon?

[puzrin]

Could you change a label? Needs-Feedback -> Bug?

[puzrin]

Problem is with this check

mocha/lib/reporters/html.js

Line 158 in 9b1e587

} else if (test.pending) {

If i change this line to

   } else if (test.pending || !test.err) {

...then code seems to work. But i'm not sure such hack is correct. Could anyone check why .pending flag is lost in test end event after this.skip()?

[mislav]

This will be fixed by #1945 (comment)

[puzrin]

Thanks for info!

[puzrin]

Still not fixed with 2.4.3. Test from the first message does not shows error on screen, but throw errors to console and mark test as failed in summary.

Something become better, but not all.

[danielstjules]

You're right - this.skip() is mostly broken in the browser. I haven't gotten around to it though.

[puzrin]

It seems to be fixed for it, but not for before (most demanded)