remove hard dependency on growl for test suite

[timbertson]

Currently mocha's own tests won't run without growl, because the checked in test/mocha.opts includes --growl.

I could change the mocha.opts locally, but I don't like being stuck with outstanding changes. I could install growl, but it's a lot of effort (and I don't actually want it).

Perhaps the --growl option should have no effect (and print a warning) if require('growl') fails?

[tj]

yeah it would be nice if we could just have it fail silently since it's not a crucial thing, no warnings

[timbertson]

86c0570 is my fix, although it logs a warning. Should be easy enough to remove that line though.

[timbertson]

Just a bump, is there any reason you haven't merged my commit above? I can break it out into its own pull request if you want, but it should be pretty trivial to cherry pick or just do by hand...

[tj]

i dont recall growl failing on a require(), but failing on growl() maybe. i'll have to take a look at the lib again i cant remember where it fails. either way I dont want to console.log() though

[tj]

This issue has been inactive for over 1 month so I'm closing it. If you think it's still an issue re-open. - tjbot

[timbertson]

just ran on master (2cc7984), and I get the following:

$ ./bin/mocha                                                

module.js:337
    throw new Error("Cannot find module '" + request + "'");
          ^
Error: Cannot find module 'growl'
    at Function._resolveFilename (module.js:337:11)
    at Function._load (module.js:279:25)
    at Module.require (module.js:359:17)
    at require (module.js:375:17)
    at growl (/home/tim/dev/oss/mocha/bin/_mocha:322:16)
    at run (/home/tim/dev/oss/mocha/bin/_mocha:315:22)
    at /home/tim/dev/oss/mocha/bin/_mocha:289:3
    at /home/tim/dev/oss/mocha/bin/_mocha:302:18
    at Array.forEach (native)
    at load (/home/tim/dev/oss/mocha/bin/_mocha:297:9)
    at Object.<anonymous> (/home/tim/dev/oss/mocha/bin/_mocha:288:1)
    at Module._compile (module.js:446:26)
    at Object..js (module.js:464:10)
    at Module.load (module.js:353:31)
    at Function._load (module.js:311:12)
    at Array.0 (module.js:484:10)
    at EventEmitter._tickCallback (node.js:190:38)

[timbertson]

I'd even be happy if I could just add "--no-growl" to revert the earlier "--growl" on the same command line. Perhaps that's a bit daft though.