Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor statistics #3256

Closed
boneskull opened this issue Mar 1, 2018 · 3 comments · Fixed by #3458
Closed

refactor statistics #3256

boneskull opened this issue Mar 1, 2018 · 3 comments · Fixed by #3458
Labels
status: accepting prs Mocha can use your help with this one! type: cleanup a refactor

Comments

@boneskull
Copy link
Member

Stat gathering (fails, passes, errors, duration) is too closely coupled to the reporter. The reporter shouldn't be the single source of truth for this information, yet it is. Statistics should be queried by the reporters instead of just dumped into the base reporter. The result may be as simple as an abstraction between the runner and reporter.

This makes it difficult to modify the stats we gather, or how we gather them.

related: #3223, #3250

@boneskull boneskull added status: accepting prs Mocha can use your help with this one! type: cleanup a refactor labels Mar 1, 2018
@Nokel81
Copy link

Nokel81 commented Mar 1, 2018

I will take a look into this do you know of a good place to start?

@craigtaub
Copy link
Contributor

craigtaub commented Aug 13, 2018

@Nokel81 been a while, any progress? Im happy to look at this too, think I know what needs to be done.

@craigtaub
Copy link
Contributor

@boneskull PR open, be interested to hear if this is/not the kind of abstraction you imagined.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: accepting prs Mocha can use your help with this one! type: cleanup a refactor
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants