Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update doc examples #3810

Closed
plroebuck opened this issue Mar 5, 2019 · 0 comments
Closed

Update doc examples #3810

plroebuck opened this issue Mar 5, 2019 · 0 comments
Labels
area: browser browser-specific good first issue new contributors should look here! nice to have enhancement proposal of low priority

Comments

@plroebuck
Copy link
Contributor

Description

"docs/example/tests.html"

  • Convert URLs to use current package releases
    • Tradeoff: minification vs. freshness
 <link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/mocha/4.0.1/mocha.min.css">
 <script src="https://cdnjs.cloudflare.com/ajax/libs/chai/4.1.2/chai.min.js"></script>
 <script src="https://cdnjs.cloudflare.com/ajax/libs/mocha/4.0.1/mocha.min.js"></script>

to

 <link rel="stylesheet" href="https://unpkg.com/mocha/mocha.css">
 <script src="https://unpkg.com/chai/chai.js"></script>
 <script src="https://unpkg.com/mocha/mocha.js"></script>

"docs/example/chai.js"

  • Determine why this is here
  • Remove from source control if no reason exists
@plroebuck plroebuck added unconfirmed-bug area: browser browser-specific nice to have enhancement proposal of low priority good first issue new contributors should look here! and removed unconfirmed-bug labels Mar 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: browser browser-specific good first issue new contributors should look here! nice to have enhancement proposal of low priority
Projects
None yet
Development

No branches or pull requests

1 participant