Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new Mocha(options) only honors options.globals, ignores options.global #3913

Closed
4 tasks done
pascalpp opened this issue May 13, 2019 · 0 comments · Fixed by #3914
Closed
4 tasks done

new Mocha(options) only honors options.globals, ignores options.global #3913

pascalpp opened this issue May 13, 2019 · 0 comments · Fixed by #3914
Labels
type: bug a defect, confirmed by a maintainer

Comments

@pascalpp
Copy link
Contributor

Prerequisites

  • Checked that your issue hasn't already been filed by cross-referencing issues with the faq label
  • Checked next-gen ES issues and syntax problems by using the same environment and/or transpiler configuration without Mocha to ensure it isn't just a feature that actually isn't supported in the environment in question or a bug in your code.
  • 'Smoke tested' the code to be tested by running it outside the real test suite to get a better sense of whether the problem is in the code under test, your usage of Mocha, or Mocha itself
  • Ensured that there is no discrepancy between the locally and globally installed versions of Mocha. You can find them with: node node_modules/.bin/mocha --version(Local) and mocha --version(Global). We recommend that you not install Mocha globally.

Description

When create a Mocha instance programmatically, options.globals is honored, but options.global is ignored. This is contrary to the docs:

Updated in v6.0.0; the option is --global and --globals is now an alias.

Steps to Reproduce

Expected behavior: options.global or options.globals should be honored

Actual behavior: only options.globals is honored

Reduced test case here: https://github.com/pascalpp/mocha-globals-repro

Reproduces how often: [What percentage of the time does it reproduce?] 100%

Versions

  • The output of mocha --version and node node_modules/.bin/mocha --version: 6.1.4
  • The output of node --version: v10.15.1
  • Your operating system
    • name and version: Mac OS X Mojave
    • architecture (32 or 64-bit): 64-bit
  • Your shell (e.g., bash, zsh, PowerShell, cmd): bash
  • Your browser and version (if running browser tests): n/a
  • Any third-party Mocha-related modules (and their versions): none
  • Any code transpiler (e.g., TypeScript, CoffeeScript, Babel) being used (and its version): none

Additional Information

See test case: https://github.com/pascalpp/mocha-globals-repro

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug a defect, confirmed by a maintainer
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants