replace str.trim() with str.replace() #533
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to make it work in IE8
| return str.trim(); | ||
| return typeof String.prototype.trim === 'function' | ||
| ? str.trim() | ||
| : str.replace(/^\s+|\s+$/g, ''); // e.g. IE 8 |
There was a problem hiding this comment.
we might as well just use this one, not like it's slow or anything, and ditch the comment
There was a problem hiding this comment.
Agree. In that case, I'd still add a comment like // str.trim() that works in IE8 - the regex is ugly and needs time to parse for a human.
There was a problem hiding this comment.
just move it into a little function trim(str) {
There was a problem hiding this comment.
Sure. E.g. a la http://stackoverflow.com/a/2308157/709537 . I don't care - just make it work! ;)
There was a problem hiding this comment.
Btw, Have I already mentioned that mocha rocks? Because it does!
|
+100 |
|
I think we use indexOf() all over too I'll take a look in sec |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to make it work in IE8