Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Output in the console Regexp object looks weird. #890

Closed
wants to merge 1 commit into from
Closed

Output in the console Regexp object looks weird. #890

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Jun 7, 2013

Output in the console Regexp object looks weird:

/a/.should.equal(5) // actual {}

I'm not sure that is clear.

Fix output in the console Regexp object.
8eca15d 
Output in the console Regexp object looks weird: {}.
@tj
Copy link
Contributor

tj commented Jun 13, 2013

we shouldn't quote them either, having "/a/" as the output isn't correct, but .eql() doesn't seem to work with regexps right now anyway, /foo/.should.eql(/bar/) seems to be truthy at the moment but that's a should bug

@tj tj closed this Jun 13, 2013
tj added a commit that referenced this pull request Jun 13, 2013
@tj
fix regexps in diffs. Closes #890
042d713
@ghost
Copy link
Author

ghost commented Jun 13, 2013

Thanks!

arunoda pushed a commit to arunoda/mocha that referenced this pull request Jun 20, 2013
@tj @arunoda
fix regexps in diffs. Closes mochajs#890
477d6ad
@afc163 afc163 mentioned this pull request Sep 4, 2014
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@tj