Change in xunit reporter in test case time when the test fails #894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the fix, but it does not solve the problem. I pulled another request #898. Cheers, |
arunoda
pushed a commit
to arunoda/mocha
that referenced
this pull request
Jun 20, 2013
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we use xunit format as the mocha reporter, when the test case fails, the time attribute in test case will be NaN. So when sonar wants to parse this xunit report, it raises parse exception which means it can not parse NaN value of time. So we replaced part related to create time value of test case
FROM : time: test.duration / 1000
TO : time: test.duration ? test.duration / 1000 : 0