Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MaximumPacketSize enforcement #120

Closed
thedevop opened this issue Dec 15, 2022 · 2 comments
Closed

MaximumPacketSize enforcement #120

thedevop opened this issue Dec 15, 2022 · 2 comments
Assignees
@mochi-co
Labels
bug Something isn't working

Comments

@thedevop
Copy link
Collaborator

Hi,

Congrats on the V2 release, features look great!

I noticed under capability, one can specify MaximumPacketSize, however, I do not see it as enforced when receiving a packet that's larger than the setting. Can you please point me to it if I missed it?
@mochi-co
Copy link
Collaborator

Hi @thedevop - I think you're right. We enforce the MaximumPacketSize specified by the client, but currently MaximumPacketSize is not being enforced for the server, even though the option exists. I will fix it 👍🏻

@mochi-co mochi-co self-assigned this Dec 15, 2022
@mochi-co mochi-co added the bug Something isn't working label Dec 15, 2022
@mochi-co mochi-co mentioned this issue Dec 16, 2022
Merged
@mochi-co
Copy link
Collaborator

Fixed in v2.0.6 - Thank you for raising it @thedevop!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mochi-co mochi-co

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mochi-co @thedevop