Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce server max packet #121

Merged
merged 3 commits into from
Dec 16, 2022
Merged

Enforce server max packet #121

merged 3 commits into from
Dec 16, 2022

Conversation

mochi-co
Copy link
Collaborator

@mochi-co mochi-co commented Dec 16, 2022

Previously, we were enforcing client maximum packet size, but not server set maximum packet size, as per #120 . This PR ensures we reject oversize packets with a 0x95 disconnect. Also fixes minor test issues.

@mochi-co mochi-co self-assigned this Dec 16, 2022
@coveralls
Copy link

Pull Request Test Coverage Report for Build 3709124322

  • 8 of 8 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.002%) to 98.173%

Totals Coverage Status
Change from base Build 3706852374: 0.002%
Covered Lines: 4996
Relevant Lines: 5089

💛 - Coveralls

@mochi-co mochi-co merged commit d8f28cb into master Dec 16, 2022
@mochi-co mochi-co deleted the enforce-server-max-packet branch December 16, 2022 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants