-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AllowClients Field to packets #14
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check if a slice of strings contains a string (until slices package available)
AllowClients field can be specified during onMessage event to selectively deliver messages
If AllowClients has been set on a packet, ensure only clients in the slice are sent the message
previously new clients generated a new server object, so system stats were not shared. This change ensures all test clients use the same server
Codecov Report
@@ Coverage Diff @@
## master #14 +/- ##
=======================================
Coverage 98.96% 98.96%
=======================================
Files 18 19 +1
Lines 2020 2027 +7
=======================================
+ Hits 1999 2006 +7
Misses 19 19
Partials 2 2
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new
AllowClients
field to the packet structure. This field can be set during theOnMessage
event hook, allowing an embedding server to selectively deliver messages to one or more clients within one or more topics based on their client id. For example:If AllowClients is nil or not set, it is ignored and the message is delivered as normal.
All unit tests passing, paho compatibility tests passing