Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable client bufio reader/writer sizes #190

Merged
merged 1 commit into from
Mar 11, 2023

Conversation

mochi-co
Copy link
Collaborator

Addresses #189 by making the client bufio.Reader and bufio.Writer sizes configurable as server options.

The new default value for the reader and writer buffers is 2048. Different values can be configured as such:

server := mqtt.New(&mqtt.Options{
    ClientNetWriteBufferSize: 1024,
    ClientNetReadBufferSize: 1024,
})

@mochi-co mochi-co marked this pull request as ready for review March 11, 2023 23:12
@coveralls
Copy link

coveralls commented Mar 11, 2023

Pull Request Test Coverage Report for Build 4394616403

  • 26 of 26 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.002%) to 98.596%

Totals Coverage Status
Change from base Build 4297329515: 0.002%
Covered Lines: 5128
Relevant Lines: 5201

💛 - Coveralls

@mochi-co mochi-co closed this Mar 11, 2023
@mochi-co mochi-co reopened this Mar 11, 2023
@mochi-co mochi-co merged commit aaf1d9d into master Mar 11, 2023
@mochi-co mochi-co deleted the expose-net-writeread-sizes branch March 11, 2023 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants