Refactor Listener WG to track clients #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
@mochi-co This code is absolutely perfect and effective, and it is also incredibly simple and clean, which is exactly what we all expect in code. Thanks. |
werbenhu
approved these changes
Sep 21, 2023
thedevop
approved these changes
Sep 22, 2023
mochi-co
deleted the
wait-for-all-clients-to-disconnect-before-continuing
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #298 and #299, this PR presents a small solution to track the connection alive status of every client by repurposing the Listeners waitgroup to track clients instead of listeners. This change ensures that the Hooks shutdown sequence cannot be completed until all clients have successfully and sequentially exited their goroutines (between cl.Read and OnDisconnect). In this way, we can leverage the existing shutdown signally code.
Tests are unaffected, Paho passing.