Move cl.WriteLoop() to attachClient() and call cl.Stop() in loadClients() to update client.State. #344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thedevop
previously approved these changes
Dec 13, 2023
…n such as disconnected time, and set the stopCause.
Pull Request Test Coverage Report for Build 7294678352
💛 - Coveralls |
werbenhu
requested review from
mochi-co and
x20080406
and removed request for
dgduncan
|
@thedevop @x20080406 @mochi-co @dgduncan I have added a call to cl.Stop() in loadClients() to cancel the client's context, update cl.State with information such as disconnected time, and set the stopCause. Please let me know if there are any other cases that need to be considered. |
werbenhu
changed the title
thedevop
approved these changes
Dec 13, 2023
x20080406
approved these changes
Dec 14, 2023
werbenhu
changed the title
mochi-co
approved these changes
Dec 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the server.loadClients() and when using inlineClient, NewClient() is called, but these may not necessarily represent actual connections. Calling go cl.WriteLoop() within NewClient() leads to a goroutine leak. I think moving go cl.WriteLoop() out of NewClient() and placing it in either server.EstablishConnection() or server.attachClient() would be more reasonable.