Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #349, MQTT v3 unsuback does not require Reason Code. #353

Merged
merged 1 commit into from
Jan 10, 2024

Conversation

werbenhu
Copy link
Member

@werbenhu werbenhu commented Dec 26, 2023

Fix #349, According to MQTT v3 spec 3.11 UNSUBACK – Unsubscribe acknowledgement, MQTT v3 UNSUBACK does not require a Reason Code.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 7328072157

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 98.75%

Totals Coverage Status
Change from base Build 7294752060: 0.0%
Covered Lines: 5529
Relevant Lines: 5599

💛 - Coveralls

Copy link
Contributor

@dadebue dadebue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested locally with MQTT.js and unsubscribing is working fine now!

@mochi-co
Copy link
Collaborator

Simple and effective, looks like I missed this when I was putting it together 🙃
Thank you very much @werbenhu and @dadebue! Sorry for delay. Feel free to tag me in the future if it's urgent and I'll do my best.

@mochi-co mochi-co merged commit 10a02ab into mochi-mqtt:main Jan 10, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Client unsubscribe topic have problem
4 participants