Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a persistence hook based on cockroachdb/pebble. #378

Merged
merged 5 commits into from Mar 28, 2024
Merged

Add a persistence hook based on cockroachdb/pebble. #378

merged 5 commits into from Mar 28, 2024

Conversation

werbenhu
Copy link
Member

No description provided.

@werbenhu werbenhu requested review from dgduncan and mochi-co and removed request for dgduncan March 26, 2024 12:40
@coveralls
Copy link

coveralls commented Mar 26, 2024 •
edited

Pull Request Test Coverage Report for Build 8447372264

Details

  • 365 of 365 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.08%) to 98.696%
Totals Coverage Status
Change from base Build 8325560205: 0.08%
Covered Lines: 6057
Relevant Lines: 6137
💛 - Coveralls

@werbenhu werbenhu requested a review from dgduncan March 26, 2024 12:41
@werbenhu werbenhu changed the title Implementing Pebble as a persistence database hook. Add a persistence hook based on cockroachdb/pebble. Mar 26, 2024
@luohao123
Copy link

Hello, does it works out of box now?

Will it still cause cached file unlimited grow?

@werbenhu werbenhu requested review from mochi-co, dgduncan and thedevop and removed request for mochi-co and dgduncan March 27, 2024 06:05
mochi-co
mochi-co approved these changes Mar 28, 2024
View reviewed changes
Copy link
Collaborator

@mochi-co mochi-co left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work @werbenhu - very impressive. Approved, will release imminently.

@mochi-co mochi-co merged commit d048e4b into mochi-mqtt:main Mar 28, 2024
3 checks passed
@luohao123
Copy link

Will release a new version so that go mod can update?

@werbenhu werbenhu deleted the pebbledb branch April 2, 2024 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mochi-co mochi-co mochi-co approved these changes

@dgduncan dgduncan Awaiting requested review from dgduncan

@thedevop thedevop Awaiting requested review from thedevop

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@werbenhu @coveralls @luohao123 @mochi-co