Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 0-length range responses. #87

Merged
merged 2 commits into from Aug 1, 2013

Commits on Nov 6, 2012

  1. Fix 0-length range responses.

    There were two issues:
    
    - file:pread() returns eof in the case when the length of the
      read is 0 bytes, for any offset.  This causes badarg exceptions
      later in iolist_size when the 'eof' atom is encountered instead
      of a binary
    
    - The range-length computation is off by 1 for 0-length ranges:
      {Skip, Skip + Length - 1, PartialBody} would result in e.g.
      {0, -1, eof}. {0, -1} is invalid HTTP according to
    
      http://tools.ietf.org/html/rfc2616#section-14.16
    
         A byte-content-range-spec with a byte-range-resp-spec whose
         last-byte-pos value is less than its first-byte-pos value,
         or whose instance-length value is less than or equal to its
         last-byte-pos value, is invalid.
    
    This patch fixes both issues.
    pmundkur committed Nov 6, 2012
    Configuration menu
    Copy the full SHA
    8ec8af1 View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2012

  1. Configuration menu
    Copy the full SHA
    526ce73 View commit details
    Browse the repository at this point in the history