Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Missing the version menu on the docs site #49

Closed
mochipon opened this issue Jul 21, 2021 · 0 comments
Closed

[Bug]: Missing the version menu on the docs site #49

mochipon opened this issue Jul 21, 2021 · 0 comments
Labels
bug Something isn't working

Comments

@mochipon
Copy link
Owner

Description - 説明

Read the Docs is able to handle multiple doc versions. Although pysesame3 is developed with backward compatibility in mind, users should be able to intentionally specify and read the version of the document they are using.

Read the Docs will inject their own javascript and css at build time, and the version (flyout) menu should appear at the bottom right of the screen. The problem is, this script depends on jQuery, but jQuery was not loaded implicitly, so the menu could not be displayed.

8a7ca4b has solved the issue. We have to cherry-pick the commit and rebuild the docs we have published so far.

Expected Behavior - 期待する動作

No response

Pysesame3 version (pip show pysesame3)

N/A

Python version (python --version)

N/A

OS

N/A

How to Reproduce - 再現方法

Open the docs site.

Output - 出力された内容, 具体的な問題内容

readthedocs-doc-embed.js:1 Uncaught ReferenceError: $ is not defined
    at Object.get (readthedocs-doc-embed.js:1)
    at Object.init (readthedocs-doc-embed.js:1)
    at HTMLDocument.n (readthedocs-doc-embed.js:1)
@mochipon mochipon added the bug Something isn't working label Jul 21, 2021
mochipon added a commit that referenced this issue Jul 21, 2021
mochipon added a commit that referenced this issue Jul 21, 2021
mochipon added a commit that referenced this issue Jul 21, 2021
mochipon added a commit that referenced this issue Jul 21, 2021
mochipon added a commit that referenced this issue Jul 21, 2021
mochipon added a commit that referenced this issue Jul 21, 2021
mochipon added a commit that referenced this issue Jul 21, 2021
mochipon added a commit that referenced this issue Jul 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant