Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Breaking Change] Default key tag is changed to pysesame3 from API #8

Merged
merged 1 commit into from Jun 14, 2021

Conversation

mochipon
Copy link
Owner

This commit allows users to set their own key tags.
Key tags will be stored in the history as the name of the key that unlocked or locked the door.
It will be more understandable when auditing the key operation using APIs and the apps.

This commit allows users to set their own key tags.
Key tags will be stored in the history as the name of the key that unlocked or locked the door.
It will be more understandable when auditing the key operation using APIs and the apps.
@codecov
Copy link

codecov bot commented Jun 13, 2021

Codecov Report

Merging #8 (12bb106) into main (4ae5529) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main        #8   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            8         8           
  Lines          273       273           
=========================================
  Hits           273       273           
Impacted Files Coverage Δ
pysesame3/cloud.py 100.00% <100.00%> (ø)
pysesame3/lock.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ae5529...12bb106. Read the comment docs.

@mochipon
Copy link
Owner Author

The biggest reason for making this disruptive change is that the value API itself is not descriptive at all. There are many different ways to use Web APIs in the world (e.g., nzws/homebridge-sesame-os2 which is great btw), and they should be distinguishable.

@mochipon mochipon merged commit c2d0083 into main Jun 14, 2021
@mochipon mochipon deleted the feat/histtag branch June 14, 2021 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant