Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: device status callback never executed #58

Closed
zhyu opened this issue Jun 18, 2022 · 0 comments · Fixed by #59
Closed

[Bug]: device status callback never executed #58

zhyu opened this issue Jun 18, 2022 · 0 comments · Fixed by #59
Labels
bug Something isn't working

Comments

@zhyu
Copy link
Contributor

zhyu commented Jun 18, 2022

Description - 説明

Everything works fine with the version 0.0.4. After I upgrade pysesameos2 to 0.0.5, I found the device status callback never executed.

I checked the source code, found the setDeviceStatusCallback of CHSesame2 wrongfully executes pass instead of calling the method extended from its parent:

def setDeviceStatusCallback(
self, callback: Optional[Callable[["CHSesame2"], None]]
) -> None:
"""Set a device status callback.
Args:
callback (Optional[Callable[[CHSesame2], None]]): The callback to be called on device status changing.
"""
pass

Expected Behavior - 期待する動作

After device status changed, the callback set with setDeviceStatusCallback should be executed.

Pysesameos2 version (pip show pysesameos2)

0.0.5

Python version (python --version)

3.9.2

OS

pi os

BlueZ version (bluetoothctl -v) in case of Linux

No response

How to Reproduce - 再現方法

Just run the example code and try to lock/unlock with mqtt command.

Output - 出力された内容, 具体的な問題内容

No response

@zhyu zhyu added the bug Something isn't working label Jun 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant