Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App dies on startup when a host machine identifier is not present in SIMachineAttributes.plist #13

Closed
ggoraa opened this issue Jan 9, 2022 · 0 comments · Fixed by #14
Assignees
Labels
bug Something isn't working

Comments

@ggoraa
Copy link
Collaborator

ggoraa commented Jan 9, 2022

No description provided.

@ggoraa ggoraa added the bug Something isn't working label Jan 9, 2022
@ggoraa ggoraa self-assigned this Jan 9, 2022
@ggoraa ggoraa added this to the 0.1.0 milestone Jan 9, 2022
@ggoraa ggoraa linked a pull request Jan 9, 2022 that will close this issue
ggoraa added a commit that referenced this issue Jan 9, 2022
@ggoraa ggoraa closed this as completed Jan 9, 2022
ggoraa added a commit that referenced this issue Jan 9, 2022
* refactor: mark renamed in NotificationKeys

* refactor: renamed MockChatLogo to MockChatPhoto

* feat: removed Chat.swift, replaced with TDLibKit's Chat struct

* feat: moved ChatItemView to using Chat struct from TDLibKit instead of ChatItem

* feat: MainViewModel updates

- removed update() function
- changed type of chatList from [ChatItem] to [Chat]

* feat: Ui improvements and start logic for implementing chat lists

* feat: first steps in implementing ChatView for actual data, not mock ones

* feat: optimized chat list updates

* feat: moved chat toolbar to ChatView

* Chat split view (#11)

* refactor: moved SearchField to a folder dedicated for AppKit bindings to SUI

* feat: created ChatSplitView storyboard and a corresponding view controller.

Thanks to https://betterprogramming.pub/using-nssplitview-in-an-macos-app-bbe2438bfe3e article!

* feat: proj updates

* feat: first attempt at implementing split view

this will be rewritten from using Storyboard and NSViewControllerRepresentable to NSViewRepresentable

* feat: removed ChatSplitView storyboard and things related to it

* feat: created SplitView view based on NSViewRepresentable and NSSplitView

* feat: implemented split view in ChatView

* feat: implemented a new ChatView

* feat: xcode stuff

* Chat inspector (#12)

* feat: removed a placeholder for the inspector

* feat: added a function to create a button for the inspector

* feat: implemented showing chat photo, name, member count, and quick action buttons

* feat: fixed the preview. now it at least exists 🤷

* feat: other changes

* feat: created an enum to represent state of the inspector tabs with a corresponding state variable

* feat: added dividers between buttons, made buttons a lil smaller

* feat: added the tab bar

* feat: fixed preview size

* refactor: renamed SplitView to ChatSplitView, moved to Views/Chat from Views/AppKitBindings

* feat: more UI updates

* feat: xcode stuff

* refactor: removed UI tests

* feat: added SwiftLint. oh boy, now i need to fix all of my shitcode

* chore: removed unused struct

* fix: inspector not fully collapsing

* chore: fixed too long line warning in MocApp

* chore: fix switch indentation warnings, safer Bundle.main calls

* chore: fix warnings in ChatView

* xcode: lottie updates

* chore: fixed warnings in ContentView, made one receiver safer

* chore: swiftlint warning fix

* chore: login view warnings fix

* fix: fixed crash on start on some devices

closes #13

* chore: even more fixes using SwiftLint
also removed Persistense.swift because of redundancy
ggoraa added a commit that referenced this issue Jan 9, 2022
* refactor: mark renamed in NotificationKeys

* refactor: renamed MockChatLogo to MockChatPhoto

* feat: removed Chat.swift, replaced with TDLibKit's Chat struct

* feat: moved ChatItemView to using Chat struct from TDLibKit instead of ChatItem

* feat: MainViewModel updates

- removed update() function
- changed type of chatList from [ChatItem] to [Chat]

* feat: Ui improvements and start logic for implementing chat lists

* feat: first steps in implementing ChatView for actual data, not mock ones

* feat: optimized chat list updates

* feat: moved chat toolbar to ChatView

* Chat split view (#11)

* refactor: moved SearchField to a folder dedicated for AppKit bindings to SUI

* feat: created ChatSplitView storyboard and a corresponding view controller.

Thanks to https://betterprogramming.pub/using-nssplitview-in-an-macos-app-bbe2438bfe3e article!

* feat: proj updates

* feat: first attempt at implementing split view

this will be rewritten from using Storyboard and NSViewControllerRepresentable to NSViewRepresentable

* feat: removed ChatSplitView storyboard and things related to it

* feat: created SplitView view based on NSViewRepresentable and NSSplitView

* feat: implemented split view in ChatView

* feat: implemented a new ChatView

* feat: xcode stuff

* Chat inspector (#12)

* feat: removed a placeholder for the inspector

* feat: added a function to create a button for the inspector

* feat: implemented showing chat photo, name, member count, and quick action buttons

* feat: fixed the preview. now it at least exists 🤷

* feat: other changes

* feat: created an enum to represent state of the inspector tabs with a corresponding state variable

* feat: added dividers between buttons, made buttons a lil smaller

* feat: added the tab bar

* feat: fixed preview size

* refactor: renamed SplitView to ChatSplitView, moved to Views/Chat from Views/AppKitBindings

* feat: more UI updates

* feat: xcode stuff

* refactor: removed UI tests

* feat: added SwiftLint. oh boy, now i need to fix all of my shitcode

* chore: removed unused struct

* fix: inspector not fully collapsing

* chore: fixed too long line warning in MocApp

* chore: fix switch indentation warnings, safer Bundle.main calls

* chore: fix warnings in ChatView

* xcode: lottie updates

* chore: fixed warnings in ContentView, made one receiver safer

* chore: swiftlint warning fix

* chore: login view warnings fix

* fix: fixed crash on start on some devices

closes #13

* chore: even more fixes using SwiftLint
also removed Persistense.swift because of redundancy

* chore: final SwiftLint fixes
yeeee

* chore: removed redundant Task arg

* xcode: xcode stuff

* fix: fixed add chat button duplication

* ui: removed dividers from buttons in inspector

* feat: small login view changes

* feat: improved chat list sorting

* other: custom logging for TDLibKit

* refactor: time rendering in ChatItemView
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant