Add support for EC keys #1384
Merged
Add support for EC keys #1384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jamesdbloom I'm a bit lost in the logs of the failing builds. Looks like it fails because some tests fail to run in parallel right? Can you help with that? |
|
@pascal-hofmann I'll try running this code on my local machine and see if I can see where the issue is as nothing looks wrong in code I can see |
|
I've found the fix for the PR it was the parsing of PEMs into private keys it didn't work in every case. I've manually merged your commits and added a commit to fix the private key PEM parsing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #924 / https://trello.com/c/zIl5yDEz/178-support-ec-certificates