Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#3: Lua 5.3 fix for unpack() #4

Merged
merged 2 commits into from
Sep 3, 2020
Merged

#3: Lua 5.3 fix for unpack() #4

merged 2 commits into from
Sep 3, 2020

Conversation

redcatbear
Copy link
Collaborator

Closes #3.

@redcatbear redcatbear added bug documentation Documentation (user-guide, change log, commiter information) labels Sep 2, 2020
@redcatbear redcatbear added this to the M1: Lua 5.3 compatibility milestone Sep 2, 2020
@redcatbear redcatbear self-assigned this Sep 2, 2020
@redcatbear
Copy link
Collaborator Author

@vertti : Please activate Travis CI GitHub app for continuous integration and switch on all branch rules for CI checks and reviews.

@vertti vertti merged commit 7240622 into master Sep 3, 2020
@vertti vertti deleted the bugfix/3-Lua_5.3_compatibiliy_with_unpack branch September 3, 2020 07:42
@vertti
Copy link
Collaborator

vertti commented Sep 3, 2020

This contained quite a lot more than just "5.3 fix". :)

Anyways, looks good! Merged and Travis is now running three builds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vertti vertti vertti approved these changes

Assignees

@redcatbear redcatbear

Labels
bug documentation Documentation (user-guide, change log, commiter information)
Projects
None yet
Milestone
M1: Lua 5.3 compatibility
Development

Successfully merging this pull request may close these issues.

Lua 5.3: Attempt to call a nil value (global 'unpack')
2 participants
@redcatbear @vertti