[Dependecy Updates] Update Packages #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- updated packages: - axios 0.5.4 >> 1.6.8 - @Edgio 7.0.17 >> 7.11.3 - esbuild 0.17.19 >> 0.20.2 - chai 3.0.0 >> 5.1.0 - mocha 2.2.5 >> 10.4.0 - nock 2.6.0 >> 13.5.4 - added packages: - eslint 8.0.1 - eslint-config-standard 17.1.0 - eslint-plugin-import 2.25.2 - eslint-plugin-n: 15.0.0 || 16.0.0 - eslint-plugin-promise: 6.0.0 - updated Sytnax as a result of package updates - updated Unit tests and fixed broken ones - added ESLint to help keep code clean and more closely aligned - removed Quote that seems to be mistakenly added to the images directory
mockaroo
reviewed
Apr 23, 2024
src/client.js
Outdated
| */ | ||
| constructor (options) { | ||
| const defaults = { | ||
| host: "mockaroo.com", |
There was a problem hiding this comment.
Suggested change
| host: "mockaroo.com", | |
| host: "api.mockaroo.com", |
This should be api.mockaroo.com, not the apex domain.
There was a problem hiding this comment.
Nice catch! Thank you!
mockaroo
requested changes
Apr 23, 2024
- updated the default `host` to be `api.mockaroo.com` instead of the apex domain `mockaroo.com`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated Packages
New Packages
Additional Updates
Vulnerabilities Before
Vulnerabilities After
NOTE
Of the critical ones I did not touch, they seem related to the use of
esdoc, so I left them untouched as they shouldn't affect the client's installation. Should we need to address these other vulnerabilities, I figured we could do this in a separate PR.