Fix trivial bugs #103
Fix trivial bugs #103
Conversation
|
|
||
| override fun invokesMany(vararg blocks: () -> R) = invokesMany(blocks.map { block -> { _ -> block() } }) |
There was a problem hiding this comment.
What is the reasoning behind removing the vararg variant?
- It's a breaking change in a patch version
- Without the vararg, every use site has to do a
listOf(...)or create a helper function to polyfill the existing method.
You can see an example failure here:
TWiStErRob/net.twisterrob.travel#207 (comment)
and an example fix:
TWiStErRob/net.twisterrob.travel@e294dfa
I'm only using this in a single class, imagine a project that fully relies on this...
There was a problem hiding this comment.
Good point @TWiStErRob! I guess I imagined nobody actually used this function since I personally didn't think it was that useful. I'll add it back in and release a hotfix for it in v2.2.2 shortly, and be more careful of retaining backward compatibility going forward, making sure to use @Deprecated warnings for future occurrences.
There was a problem hiding this comment.
No worries.
Tip: write tests for these methods and it'll show you when they're useful, and whether the DX of them is good :)
SuspendResultBuilder.invokesandResultBuilder.invokes#73 by removing unnecessary invoke functionsMissingExpectationExceptionwhen switching Coroutine Context in iOS #98 by making mockable map non-thread-local