fix(Android): failure when faking sealed classes #92
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
valueOf
causes NPE on Android for sealed classes #87Issue
When running Android Instrumented tests with parameters that are sealed classes on Android or in older JVMs, a NullPointerException is thrown.
How to reproduce
./gradlew :shared:connectedDebugAndroidTest
Cause
When running on Android or in older JVMs, the JVM functions
Class$isSealed
andClass$getPermittedSubclasses
do not exist, so the sealed class will fall onto theabstract
case inmakeValueOf
.Solution
Use Kotlin Reflect to read the Kotlin metadata from the class instead of trying to just use these functions that may not exist during runtime.
Known issue
While investigating this, I also noticed that the test
ValueOfTests.makeValueOfReturnsOtherStuff
fails when trying to getvalueOf<AbstractParameter>()
. I've created #91 to handle the abstract class case.