Fix type hints in the generator to return an absolute class name. Thi…

…s fixes a bug with namespaces.
mockery · Feb 26, 2019 · 36fe152 · 36fe152
1 parent be9bf28
commit 36fe152
Show file tree

Hide file tree

Showing 2 changed files with 40 additions and 1 deletion.
diff --git a/library/Mockery/Generator/Parameter.php b/library/Mockery/Generator/Parameter.php
@@ -48,7 +48,7 @@ public function getTypeHintAsString()
         if ((version_compare(PHP_VERSION, '5.4.1') >= 0)) {
             try {
                 if ($this->rfp->getClass()) {
-                    return $this->getOptionalSign() . $this->rfp->getClass()->getName();
+                    return $this->getOptionalSign() . '\\' . $this->rfp->getClass()->getName();
                 }
             } catch (\ReflectionException $re) {
                 // noop

diff --git a/tests/Mockery/Generator/ParameterTest.php b/tests/Mockery/Generator/ParameterTest.php
@@ -0,0 +1,39 @@
+<?php
+
+namespace Mockery\Generator;
+{
+    class ParameterTest extends \PHPUnit_Framework_TestCase
+    {
+        /**
+         * @test
+         */
+        public function shouldBringIteratorAggregateToHeadOfTargetListIfTraversablePresent()
+        {
+            $rfp = new \ReflectionParameter(array('\TestSubjectNameSpace\TestSubject', 'foo'), 0);
+            $parameterGenerator = new Parameter($rfp);
+            $typeHint = $parameterGenerator->getTypeHintAsString();
+
+            $this->assertEquals('\TypeHintNameSpace\TypeHint', $typeHint);
+        }
+    }
+}
+
+namespace TypeHintNameSpace;
+{
+    class TypeHint
+    {
+    }
+}
+
+namespace TestSubjectNameSpace;
+use TypeHintNameSpace\TypeHint;
+{
+    class TestSubject
+    {
+        public function foo(TypeHint $param)
+        {
+        }
+    }
+}
+
+