-
Notifications
You must be signed in to change notification settings - Fork 461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove hamcrest/hamcrest-php
package
#1227
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghostwriter
changed the title
Remove
Remove Apr 12, 2023
hamcrest/hamcrest-php
deprecated packagehamcrest/hamcrest-php
and deprecate package usage
ghostwriter
changed the title
Remove
Remove Apr 12, 2023
hamcrest/hamcrest-php
and deprecate package usagehamcrest/hamcrest-php
and deprecate usage
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## 2.0.x #1227 +/- ##
============================================
- Coverage 77.43% 77.37% -0.07%
+ Complexity 994 989 -5
============================================
Files 74 74
Lines 2526 2519 -7
============================================
- Hits 1956 1949 -7
Misses 570 570
|
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
ghostwriter
force-pushed
the
feature/remove-deprecated-package
branch
from
April 30, 2023 10:32
bfd8334
to
96c2c58
Compare
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
ghostwriter
changed the title
Remove
Remove Apr 30, 2023
hamcrest/hamcrest-php
and deprecate usagehamcrest/hamcrest-php
package
ghostwriter
added
the
Removed
for features or functionality that have been removed in this release
label
May 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch includes the following changes:
Hamcrest
from the source code.Hamcrest
from the documentation.hamcrest/hamcrest-php
package #1245 usage in1.6.x
.2.0.x
.The goal of this PR is to drop
Hamcrest
in favor of PHPUnit Assertions.