Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hamcrest/hamcrest-php package #1227

Merged
merged 11 commits into from
May 1, 2023

Conversation

ghostwriter
Copy link
Member

@ghostwriter ghostwriter commented Apr 12, 2023

This patch includes the following changes:

The goal of this PR is to drop Hamcrest in favor of PHPUnit Assertions.

@ghostwriter ghostwriter changed the base branch from 1.5.x to 2.0.x April 12, 2023 00:06
@ghostwriter ghostwriter changed the title Remove hamcrest/hamcrest-php deprecated package Remove hamcrest/hamcrest-php and deprecate package usage Apr 12, 2023
@ghostwriter ghostwriter changed the title Remove hamcrest/hamcrest-php and deprecate package usage Remove hamcrest/hamcrest-php and deprecate usage Apr 12, 2023
@ghostwriter ghostwriter added this to the 2.0.0 milestone Apr 20, 2023
@codecov-commenter
Copy link

codecov-commenter commented Apr 30, 2023

Codecov Report

Merging #1227 (739a237) into 2.0.x (1d82d54) will decrease coverage by 0.07%.
The diff coverage is 50.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@             Coverage Diff              @@
##              2.0.x    #1227      +/-   ##
============================================
- Coverage     77.43%   77.37%   -0.07%     
+ Complexity      994      989       -5     
============================================
  Files            74       74              
  Lines          2526     2519       -7     
============================================
- Hits           1956     1949       -7     
  Misses          570      570              
Impacted Files Coverage Δ
library/Mockery/Expectation.php 95.40% <ø> (-0.06%) ⬇️
library/Mockery/Configuration.php 66.66% <50.00%> (-1.91%) ⬇️

Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
@ghostwriter ghostwriter force-pushed the feature/remove-deprecated-package branch from bfd8334 to 96c2c58 Compare April 30, 2023 10:32
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
@ghostwriter ghostwriter added the Major Backwards Incompatible changes label Apr 30, 2023
@ghostwriter ghostwriter changed the title Remove hamcrest/hamcrest-php and deprecate usage Remove hamcrest/hamcrest-php package Apr 30, 2023
@ghostwriter ghostwriter added the Removed for features or functionality that have been removed in this release label May 1, 2023
@ghostwriter ghostwriter merged commit 50fe0b9 into 2.0.x May 1, 2023
9 checks passed
@ghostwriter ghostwriter deleted the feature/remove-deprecated-package branch May 2, 2023 09:52
@ghostwriter ghostwriter self-assigned this May 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Major Backwards Incompatible changes Removed for features or functionality that have been removed in this release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants