Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vimeo/psalm and psalm/plugin-phpunit #1230

Merged
merged 6 commits into from Apr 14, 2023
Merged

Conversation

ghostwriter
Copy link
Member

This pull request adds the Psalm as a development dependency to the project.

Psalm is a static analysis tool that can help identify errors in PHP code before it's even run, which can save time and improve the overall quality of the codebase.

Motivation

The motivation for adding Psalm as a dev dependency is to improve the quality of the project's codebase by catching potential errors before they can cause issues in production. By running Psalm as part of the development process, we can identify and fix these errors earlier in the development cycle, which can save time and effort in the long run.

Changes Made

  • Added vimeo/psalm and psalm/plugin-phpunit to the composer.json file under the require-dev section.
  • Added new psalm.xml.dist and psalm-baseline.xml files to the project, which includes the configuration settings for running Psalm.
  • Added composer scripts

Scripts

composer check
composer test
composer phpunit
composer psalm

Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
@ghostwriter ghostwriter changed the base branch from master to 1.5.x April 12, 2023 02:54
@ghostwriter
Copy link
Member Author

Based on the changes in this pull request, it only adds Psalm, a development tool, and does not affect the userland code in any way. https://github.com/mockery/mockery/pull/1230/files

Therefore, I am going to proceed and merge this pull request to continue building on top of this.

@ghostwriter ghostwriter merged commit 569f04d into 1.5.x Apr 14, 2023
6 of 8 checks passed
@ghostwriter ghostwriter deleted the feature/add-vimeo-psalm branch April 15, 2023 00:53
@ghostwriter ghostwriter added this to the 1.5.2 milestone Apr 20, 2023
@ghostwriter ghostwriter mentioned this pull request Apr 22, 2023
@ghostwriter ghostwriter added Patch Backwards compatible bug fixes and improvements Chore for non-functional changes or maintenance tasks such as code cleanup, formatting, or dependency upda labels Apr 30, 2023
@ghostwriter ghostwriter self-assigned this May 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Chore for non-functional changes or maintenance tasks such as code cleanup, formatting, or dependency upda Patch Backwards compatible bug fixes and improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant