Prevent shouldNotReceive from getting overridden by invocation count methods

[ghostwriter]

Resolves #1328

Currently, to indicate that an expectation is never expected to be called, Mockery internally sets the invocation count to 0 using Mocker\Expectation::never() which is equivalent to times(0).

So adding additional once(),twice(), times(n) invocation count methods will change the expectation behavior from shouldNotReceive to shouldReceive.

warning
Chaining additional invocation count methods to shouldNotReceive(), never(), and times(0) has been deprecated and will throw an exception in a future version of Mockery.

throw new \InvalidArgumentException(
'shouldNotReceive() method does not accept chaining additional invocation count methods.'
);

If the mock shouldNotReceive a call more or less than x times, use Call count modifiers atLeast() or atMost().

[codecov]

Codecov Report

Merging #1329 (fe754a2) into 1.6.x (b8e0bb7) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Additional details and impacted files

@@             Coverage Diff              @@
##              1.6.x    #1329      +/-   ##
============================================
+ Coverage     77.66%   77.70%   +0.04%     
- Complexity     1016     1018       +2     
============================================
  Files            76       76              
  Lines          2601     2606       +5     
============================================
+ Hits           2020     2025       +5     
  Misses          581      581              

Files Changed	Coverage Δ
library/Mockery/Expectation.php	95.53% <100.00%> (+0.08%)	⬆️

[ghostwriter]

I left this pull request open but received no response for discussion, again.

I will merge it now, but welcome any feedback post-merge.

Thanks!

[Danny-Smart]

No news is good news 😄

I found no fault when I checked this before