Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove a load of trailing whitespace and minor travis improvement #254

Closed
wants to merge 2 commits into from
Closed

Remove a load of trailing whitespace and minor travis improvement #254

wants to merge 2 commits into from

Conversation

GrahamCampbell
Copy link
Contributor

No description provided.

@aik099
Copy link

aik099 commented Jan 18, 2014

@davedevelopment , why don't we connect Scrutinizer CI to be able to validate PSR2 compatibility automatically?

before_script:
- composer install --dev
- composer self-update
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see no particular use for this one, because Travis us updating it's version of Composer each week anyway.

@davedevelopment
Copy link
Collaborator

@aik099 I think that's something we can look at down the line, the code base could probably do with a bit of a clean up beforehand, we probably wouldn't be able to see the wood for the trees.

@davedevelopment
Copy link
Collaborator

@GrahamCampbell can you rebase please.

@GrahamCampbell
Copy link
Contributor Author

Sure. Give me 10 mins. Tad busy...

@GrahamCampbell
Copy link
Contributor Author

I'll split up travis changes from the cs fixes. Time for a new pull...

@GrahamCampbell
Copy link
Contributor Author

Travis tweaks at #255.

@GrahamCampbell
Copy link
Contributor Author

CS fixes in #256, #257, and #258.

@GrahamCampbell
Copy link
Contributor Author

And #259...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants