-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor the geopotential computations to make them simpler and faster #1941
Conversation
physics/geopotential_body.hpp
Outdated
r_norm = Sqrt(r²); | ||
|
||
λ = SIUnit<Angle>() * std::atan2(y / SIUnit<Length>(), | ||
x / SIUnit<Length>()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use ArcTan, that way we don't need the SIUnit spam.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
physics/geopotential_body.hpp
Outdated
double const cos_mλ = Cos(mλ); | ||
double const 𝔏 = Cnm * cos_mλ + Snm * sin_mλ; | ||
|
||
Vector<Inverse<Length>, Frame> 𝔅_times_grad_𝔏; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just call it 𝔅_grad_𝔏.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
Retest this please |
1 similar comment
Retest this please |
No description provided.