Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vessel destruction is expensive #3379

Closed
pleroy opened this issue Jun 19, 2022 · 2 comments
Closed

Vessel destruction is expensive #3379

pleroy opened this issue Jun 19, 2022 · 2 comments

Comments

@pleroy
Copy link
Member

pleroy commented Jun 19, 2022

While replaying the journal for #3375, I am noticing that destroying a vessel is rather expensive (in some cases, 20-30 seconds). I have not investigated why, but I suspect that the vessels that are slow to destroy have tons of checkpoints. We might want to address this note sooner rather than later. Or we might want to put the vessel in an arena. Or both.

@pleroy
Copy link
Member Author

pleroy commented Aug 27, 2022

Note that #3385 addressed most of the problem. An arena might still make sense, but it would add code complexity.

@pleroy
Copy link
Member Author

pleroy commented Oct 28, 2023

Arenas don't work well with STL or absl containers, so nothing left to do here.

@pleroy pleroy closed this as completed Oct 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant