-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kerbals on EVA spawn several meters away from the vessel #1452
Comments
Thanks for the report. We were able to reproduce it. Will investigate more. |
Update: I do not see the message |
See the following link for the diff of the adapter between the state when we tested solved the ladder bug (where EVA still worked) and Cauchy: b7f6b86...2017062403-Cauchy. |
That seems to be it, I'll have to figure out why it breaks EVA spawning though, because we still need #1307 to stay fixed. |
Ok, the explanation is that when an EVA Kerbal is created, it ignores collisions with the ship that spawned it for a little while. This appears to be done by nudging it back to the airlock in the same way we nudge things, after yielding WaitForFixedUpdate; since we expect nothing to run there, random things ensue (it happens that nudging the transforms of the rigid bodies nudges the airlocks, while nudging the rigid bodies themselves did not, which is why the fix for #1307 uncovered this). if (vessel.isEVA && !vessel.evaController.Ready) {
reasons.Add("vessel is an unready Kerbal");
} The Kerbal becomes known to Principia and is nudged exclusively by us once it is ready. I will make a CL tomorrow to fix this. |
Since Cauchy, kerbals on EVA from a vessel in orbit spawn several meters away from the vessel. Doesn't happen when EVA-ing on ground or in atmosphere.
The text was updated successfully, but these errors were encountered: