-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error Not Being Raised for Non Existent Zip #3
Comments
The same seems to happen with the file exists but is not a valid zip. |
@cancan101 I will fix this ASAP. |
Also seeing this problem... But even when the file exists and is a valid zip, this doesn't seem to work... any tips on debugging? |
@WestleyArgentum I'm using I would improve this. |
I'm using |
@WestleyArgentum You mean the promise is just hanging? |
@WestleyArgentum I think maybe you're dong something wrong wth promise code, e.g. not return the promise from the inner promise chain which I have ran into before. |
Sorry I disappeared there, but in this case I don't think the error is promise related -- my code is just like the example:
Does that look ok? |
Ah, I realized I can use xcode to step through the code and my problem was with directories. Would be really cool to have those errors raised through Thanks for your help! |
@WestleyArgentum oh, can you explain a little bit about your resolution? So I can collect errors should be raised. |
So, I've never spent much time in objective c, but I think the problem is here: https://github.com/plrthink/react-native-zip-archive/blob/master/RNZipArchive.m#L19 It looks like these methods take in a pointer to a pointer to an error: https://github.com/plrthink/react-native-zip-archive/blob/fb47345d3094e7e85bf49af747758acea7fe43d3/SSZipArchive/SSZipArchive.m#L47 And that you should pass that in, check if it gets set, and raise an error instead of calling the callback |
fixed with b622cb0 |
nice, thanks! |
Tis is calling the
then
rather thancatch
where the specified file does not exist:The text was updated successfully, but these errors were encountered: