Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mockito 3 support #355

Closed
jaredsburrows opened this issue Aug 10, 2019 · 5 comments · Fixed by #417
Closed

Mockito 3 support #355

jaredsburrows opened this issue Aug 10, 2019 · 5 comments · Fixed by #417

Comments

@jaredsburrows
Copy link

Mockito was recently released - https://github.com/mockito/mockito/releases

@nhaarman
Copy link
Collaborator

Without having tried it, since there aren't any API changes - only java 8 is now required - it should work if you manually require 3+?

@jaredsburrows
Copy link
Author

Based on this PR: jaredsburrows/android-gif-search#106, we should be good. It works fine in my Robolectric tests atleast.

@azizbekian
Copy link

@nhaarman , fyi, we've had this subtle issue when using mockito3 with mockito-kotlin.

@aaronweihe
Copy link

@nhaarman , fyi, we've had this subtle issue when using mockito3 with mockito-kotlin.

Mockito 3.5.12+ has byte buddy 1.10.15 so this should no longer a problem with mockito 3.

@aaronweihe
Copy link

should a 3.x branch open for mockito 3 upgrade?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants