Cats integration #107
Merged
Cats integration #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…se Equality is used
Krever
approved these changes
May 9, 2019
There was a problem hiding this comment.
Looks great.
Three things to consider:
- Do we want to put it in docs? Might make it easier to discover even that the feature itself is trivial and self explanatory.
- Alternative syntax could be
shouldReturnPureandshouldReturnFailedbut Im not sure if its any better. I'm happy with the current one but this is something to consider. - Maybe we could post link to the PR in cats gitter room and ask for feedback there? There might be some insightful comments from the cats user base.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.