Close mocking session on aborted Scalatest runs #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| case NonFatal(ex) => | ||
| session.finishMocking(Some(ex)) | ||
| throw ex | ||
| case t: Throwable => |
There was a problem hiding this comment.
So the problem was that we were not catching the StackOverflowException and hence not closing the session appropriately?
There was a problem hiding this comment.
yep, and NonFatal(e) wouldn't catch it either - StackOverflowError is a VirtualMachineError which is technically fatal for some reason even if it's not
There was a problem hiding this comment.
And in synchronous spec, no exceptions are caught - but some do get thrown when a suite is aborted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #211 .
A Scalatest test case run (
super.withFixture(test)) will actually throw an exception when the entire test suite must be aborted (ie initialization errors or just non-Exceptionerrors such asStackOverflowError). In such a case, the current open mocking session is never closed, and all subsequent test suites using the same base class start to fail because Mockito does not allow creating a new session when there's an unclosed one.We can fix it by catching all throwables, trying to close the session and rethrow.