Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve BaseStubbing & ThrowsException internals #1323

Closed
dmitry-timofeev opened this issue Feb 23, 2018 · 0 comments
Closed

Improve BaseStubbing & ThrowsException internals #1323

dmitry-timofeev opened this issue Feb 23, 2018 · 0 comments

Comments

@dmitry-timofeev
Copy link
Contributor

dmitry-timofeev commented Feb 23, 2018 •
edited

I'd discovered some exception-stubbing related code that may express its intent more clearly during #1322 investigation.

Please see the PR for more details: #1324
dmitry-timofeev added a commit to dmitry-timofeev/mockito that referenced this issue Feb 23, 2018
@dmitry-timofeev
Fixes mockito#1323: Clarify intentions in BaseStubbing:
8c90f8c 
Replace an obsolete TODO with a clarifying comment
and add some tests covering related test cases.

Also, extract the code aborting the ongoing stubbing
in a separate method that always throws.
Use return `abortNullExceptionType` so that
static-analysis tools (e.g., IDEA) yield no false-positives.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dmitry-timofeev